Bug: writeLog has incorrect Web name

StoreDotPm uses the init web instead of the web name supplied to the save function. The webs are usually the same since TWiki gets initialized with the web of the to-be-saved topic. It fails if a Plugin calls TWiki::Func::saveTopicText() with a web other then the one used during initialization.

Test case

• I installed the GlobalReplacePlugin on TWiki.org to batch-fix the PluginAppraisal topics
• The replace form is located in the TWiki web, GlobalSearchAndReplace (Plugin is disabled now for security)
• After replacing text in many appraisal topics I expected to find the changes logged in Plugins.WebStatistics, they are incorrectly logged in TWiki.WebStatistics.

Example:

| 03 Nov 2004 - 00:26 | Main.PeterThoeny | save | TWiki.QuickCalendarPluginAppraisal | repRev 1.2 Main.PeterThoeny 2004/11/03 08:10:40 | 67.120.104.69 |
| 03 Nov 2004 - 00:26 | Main.PeterThoeny | save | TWiki.QuickPostPluginAppraisal | repRev 1.2 Main.PeterThoeny 2004/11/03 08:10:40 | 67.120.104.69 |

TWiki.QuickCalendarPluginAppraisal should be Plugins.QuickCalendarPluginAppraisal

Environment

-- PeterThoeny - 04 Nov 2004

Follow up

In sub saveNew, fix variables from $TWiki::webName to $web. This is for .changes log and access log.

-- PeterThoeny - 04 Nov 2004

Fix record

FYI this does not apply to DEVELOP where it is already fixed (was never broken).

-- CrawfordCurrie - 04 Nov 2004

I take that back - it applies to .changes. Fixed on DEVELOP, version 1809.

-- CrawfordCurrie - 04 Nov 2004

Thanks Crawford for the .changes fix. However, writeLog is incorrect in DEVELOP:

TWiki::writeLog( "save", "$TWiki::webName.$topic", $extra );

There are three instances.

-- PeterThoeny - 04 Nov 2004

OK, in 1819

-- CrawfordCurrie - 05 Nov 2004