Tags:
archive_me1Add my vote for this tag create new tag
view all tags
Sorry if this may not be completely reproducible...

Our WebHome page got empty, i.e. RCS created an empty current version.

While trying to test different URL-based authorization schemes and robustness on bad inputs, I tried the following URLs /twiki/bin/save/foo and /twiki/bin/save or /twiki/bin/save/

I think the latter got me, after quite some delay, surprisingly to the page WebHome - which as a result is now empty.

It looks like TWiki invoked RCS for an update to the WebHome as a result of the bad URL, and afterwards barfed without completing the job (or it really thought that the submitted page is empty).

-rw-r-----	1 x		y			16 Aug 23 13:37 WebHome.lock
-rw-r--r--	1 x		y			 0 Aug 23 13:37 WebHome.txt
-r--r--r--	1 x		y		 5326 Aug 23 13:37 WebHome.txt,v

data/logfile.txt says:

23 Aug 2000 - 13:34 TWikiGuest view Main r1.5 n.n.n.n
23 Aug 2000 - 13:34 TWikiGuest view Main   n.n.n.n
23 Aug 2000 - 13:37 JoergHoehle save Main repRev 1.6 JoergHoehle 2000/08/23 11:20:31 n.n.n.n

Apache 1.3.1 log says:
Use of uninitialized value at wiki.pm line 855.
Use of uninitialized value at wiki.pm line 856.
Use of uninitialized value at wikicfg.pm line 190.
Use of uninitialized value at wikicfg.pm line 191.
Use of uninitialized value at (eval 11) line 1.
[...once for every line 12-17]
Use of uninitialized value at (eval 18) line 1.
Use of uninitialized value at wiki.pm line 868.
[once for every line from 869 to 893]
Use of uninitialized value at wiki.pm line 894.
Use of uninitialized value at wiki.pm line 992.
Use of uninitialized value at wiki.pm line 993.
Use of uninitialized value at wiki.pm line 994.
[Wed Aug 23 13:34:39 2000] [error] malformed header from script. Bad header=<HEAD>: /twiki/20000501/bin/save
[Wed Aug 23 13:35:14 2000] [error] malformed header from script. Bad header=<HEAD>: /twiki/20000501/bin/save
[Wed Aug 23 13:35:15 2000] [error] script not found or unable to stat: /twiki/20000501/bin/foo
[Wed Aug 23 13:35:19 2000] [error] malformed header from script. Bad header=<HEAD>: /twiki/20000501/bin/save
[Wed Aug 23 13:35:39 2000] [error] script not found or unable to stat: /twiki/20000501/bin/foo
[Wed Aug 23 13:36:46 2000] [error] malformed header from script. Bad header=<HEAD>: /twiki/20000501/bin/save
Use of uninitialized value at wiki.pm line 94.
Use of uninitialized value at wiki.pm line 98.
Use of uninitialized value at /twiki/20000501/bin/save line 50.
Use of uninitialized value at /twiki/20000501/bin/save line 53.
Use of uninitialized value at /twiki/20000501/bin/save line 56.
Use of uninitialized value at /twiki/20000501/bin/save line 59.

Would it be useful to add more checks?

-- JoergHoehle - 23 Aug 2000


The current save script assumes that it is called by the preview script. There is a possibility that things go wrong if invoked separately, like in your case. It should be made more robust, e.g. check if the parameters are correct and save only if they are. One check is the make sure the text is not empty (this would prevent one from saving an empty topic)

-- PeterThoeny - 29 Aug 2000

Fixed (added test of undefined $text) and commited to TWikiAlphaRelease.

-- PeterThoeny - 06 Nov 2000

TopicClassification:
BugResolved
Edit | Attach | Watch | Print version | History: r3 < r2 < r1 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r3 - 2000-11-07 - PeterThoeny
 
  • Learn about TWiki  
  • Download TWiki
This site is powered by the TWiki collaboration platform Powered by Perl Hosted by OICcam.com Ideas, requests, problems regarding TWiki? Send feedback. Ask community in the support forum.
Copyright © 1999-2026 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.