Bug: No 'Cancel Edit' link when SKIN = iejs
This is true on twiki.org as well as my own.
Test case
- edit any page and manually append '&skin=iejs' to the URL
- Go to your user page and set 'SKIN = iejs' example
- then edit a page
Fix record
I found an
HTML error in the edit.iejs.tmpl. The name parameter had an open quote, but no closing one.
Correcting this corrects the problem with the cancel hyperlink and the text that is displayed for the "Preview Changes" button.
Incorrect:
<input type="submit" name=" value="Preview Changes" />
Corrected:
<input type="submit" name="submit button" value="Preview Changes" />
The edit.iejs.tmpl on
JavascriptBasedEditor has been updated with the correction.
Environment
| |
matt's |
twiki.org |
| TWiki version: |
01Sep2001 |
? |
| TWiki plugins: |
default, PowerEditAddon |
? |
| Server OS: |
Cygwin-NT4 |
? |
| Web server: |
Apache |
? |
| Perl version: |
Cygwin-5.6.1 |
? |
| Client OS: |
W2k |
W2k |
| Web Browser: |
IE5.5 |
IE5.5 |
--
MattWilkie - 26 Oct 2001
Well, I still can't iejs to work for me. TWiki.org does not recognise the &skin=iejs directive despite me having the SKIN setting on
Main.MartinCleaver
Are you sure it works on TWiki.org?
--
MartinCleaver - 27 Oct 2001
Yep, still happens for me on twiki.org. Maybe it is browser version dependent? For
iejs I'm using Internet Explorer v5.5. It doesn't work at all with Mozilla 0.9.4, reverting to the regular form edit.
(I notice I did neglect to fill in the browser details in the table; I fixed that oversight)
--
MattWilkie - 29 Oct 2001
Bizzare. I am using IE 5.5, but I get the regular form edit. Any ideas? Does anyone else have problems?
--
MartinCleaver - 29 Oct 2001
I noticed the same thing, here on twiki.org and on my installation. I edited the edit.iejs.tmpl file, noticed that everything looked OK. The next time I tried, it was working OK. Strange.
I've also attempted to figure out why the button says "Submit Query" instead of "Preview Changes."
I found the problem, as described in the Fix Record above. I have updated the edit.iejs.tmpl on
JavascriptBasedEditor. This change needs to be applied to twiki.org also.
--
MikeBarton - 18 Nov 2001
Is fixed and in
TWikiAlphaRelease. Thanks for reporting.
Please let the
CoreTeam change the classification to
BugResolved (at the time of fix in Alpha), otherwise we might miss a fix.
--
PeterThoeny - 20 Nov 2001