I should be painting my house...

but I'm far better at coding, which I hope will not give you an idea of how my kitchen looks like right now!

anyhow: although I don't like Perl I do like TWiki and I try to introduce it into any organization I happen to work for. from time to time "we" (this is intentionally left unspecified!) think that we could use an addition into TWiki and "we" specify and code it (or the other way round, the result is more or less the same).

specifically, I have added one 'date' parameter to the %SEARCH% function, and I want to find it back in TWiki next time I download it. CrawfordCurrie suggested me to join the crew, writing "DevelopBranch has introduced the new module TWiki::Time, which would seem to me to be a logical place to create a time interval object. I have an interest in you doing that, because it makes sense to use your internal spec in MailerContrib and ActionTrackerPlugin."

I'm not sure how much time I can use at this and I'm sure I don't like Perl, but I am willing to give it a try.

from time to time "we" have other ideas... like using TWiki user groups as mailing lists...

-- MarioFrasca - 24 Feb 2005

Hi Mario,

I don't like perl either

If you create patches and attach them to change proposals, I can usually react and put them in. All you need is an SVN checkout area and then do an svn diff > mychanges.diff to generate a diff file. Then attach that file to a ChangeProposal (not forgetting testcases and unit tests, of course).

If the traffic gets too high, or nobody is acting on the ChangeProposals, we can add you to the list of people with checkin rights, but for low volume changes this system works pretty well.

-- CrawfordCurrie - 25 Feb 2005

Mario, I can't do anything at the moment, as ntwiki is still dead (can't check in). Rather than building up loads of changes and checking them all in at once, I'm going to wait until it recovers. The patches look good, BTW, though I don't see the updates to the documentation for the interval specs? Or Testcases?

-- CrawfordCurrie - 07 Mar 2005

Hi Crawford, I noticed that the svn server is down again, I wanted to check if the SearchRenderMaxlen.diff was really necessary. updates to documentation or testcases? no, not now. too busy at work and in need of some relax afterwards. I would leave the doc as it is on the SearchByDate page and the testcases as a TODO.

-- MarioFrasca - 07 Mar 2005

The newline piece at least is needed. I played around with the logic of summary generation a lot, to try to make it more useful. makeTopicSummary already truncates to 162 chars; you are perhaps seeing the result of a change comparison, rather than a topic summary?

-- CrawfordCurrie - 08 Mar 2005

what is makeTopicSummary? I was using the old syntax ($summary). you can see it on my system (it is running today). http://kruiskruid.demon.nl/

the search on the entry page needed this patch.

on kruiskruid it is on one single line, I broke it here to make it more readable, actually the curly braces should be enough for making TWiki understand not to stop searching for the closing }% just because it came across a "\n".

%SEARCH{"." regex="on" format="| [[$web.$topic][$topic]]<br/> $summary(120) | $wikiusername | $isodate |"
date="P1w/$today" web="Main Ibo Sandbox" scope="text" regex="on" nosearch="on" nototal="on" }% 

-- MarioFrasca - 08 Mar 2005

Oh ok - sorry, I thought you had fixed something that I knew I had broken

ntwiki is back.

-- CrawfordCurrie - 08 Mar 2005

at times I get the feeling that things on my -dev twiki site would be a lot better if I could also write to SVN, not only receive from it... at times I get a broken TWiki, have to patch it locally, and I have no idea how to signal to the others... so either I post a debugTopic (but this causes more noise than good) or I hope that someone else will notice the problem and solve it, which is not the way you should behave in this kind of open source... I did not find the place where you can find the discussion about current commits, nor the web interface to svn, a sort of viewsvn.cgi ...

-- MarioFrasca - 17 Mar 2005

There is no viewsvn, AFAIK. Commits are notified on the twiki-dev mail list, which is where most people keep up with them. They are also sometimes discussed on TWikiIRC. The only reason I was initially unsure about giving you checkin rights was that I hadn't had a chance to see any of your patches / improvements at that time. It's a very fair point that I'm not keeping up with your patch traffic. I think it would be a good idea if you could check in as well. Sven, can you do the business?

-- CrawfordCurrie - 17 Mar 2005

yep, i'm happy to do it - I'll enable you this weekend

Welcome to the DEVELOP branch

-- SvenDowideit - 18 Mar 2005

good, thanks. now I have to read the SVN instructions more carefully and see which way the group cooperates. I'll be posting -as soon as I realize I'm enabled- a few smaller patches for things that have already been accepted.

-- MarioFrasca - 18 Mar 2005

The main thing is to make sure there's a Codev topic that documents the change you are checking in. Oh, and to make sure that all the tests pass (unit tests and interactive testcases) before checking in.

-- CrawfordCurrie - 18 Mar 2005

testing??? Crawford, I'm a matematician: I don't test to prove correctness, tests are to prove incorrectness, correctness is proved by logic

about documenting, ok, received.

-- MarioFrasca - 18 Mar 2005

Welcome Mario to the development group!

-- PeterThoeny - 31 Aug 2005

uploaded patches

• SearchRenderMaxlen.diff: repair the $summary function of %SEARCH% in svn 3765.
• SearchByDate.diff: added parameter date to %SEARCH% (svn 3765)