Patch Proposal: GnuSkin Twiki/GnuSkin/twikiblue.css (and probably green) have strange highlighting
Motivation
Because the existing stylesheet erroneous highlights ANCHORS instead of LINKS, and because Twiki makes ANCHORS out of certain things like headers, the resulting highlighting when using
GnuSkin is strange. Headings (e.g., ---+++) are highlighted as though they were a link, and are underlined when hovering over.
Description
Correct the
GnuSkin stylesheet. The change is based on looking at the twikiblue.css, but same problem also exists in twikigreen.css.
Documentation
If necessary, user documentation of any new features introduced by this patch.
Examples
Implementation
Sorry this isn't a patch. But it's pretty straightforward.
If you change the lines in Twiki/GnuSkin/twikiblue.css,
from
A { color: #0080CC; text-decoration: none;}
A:active { color: #0080CC; text-decoration: none;}
A:hover { color: #0080FF; text-decoration: underline;}
A:visited { color: #663399; text-decoration: none;}
A:visited:hover { color: #993399; text-decoration: underline;}
to
:link { color: #0080CC; text-decoration: none;}
:link:active { color: #0080CC; text-decoration: none;}
:link:hover { color: #0080FF; text-decoration: underline;}
:visited { color: #663399; text-decoration: none;}
:visited:hover { color: #993399; text-decoration: underline;}
everything should be fixed.
--
MarvinGreenberg - 18 Feb 2004
Discussion:
Firstly, thanks for your contribution.
Secondly: While this would probably be a good change for the
GnuSkin, it's not a
PatchProposal. This is because
GnuSkin doesn't come with TWiki and therefore isn't maintained by the
CoreTeam. The maintainer of
GnuSkin will have to decide whether to accept and integrate your changes. Codev isn't the forum to request that this happen - you should probably have posted this in
GnuSkin or
GnuSkinPluginDev.
Thirdly: You may want to take a look at the
author-css-patch.diff file attached to the dev topic - it looks like a pre-existing fix. Unfortunately, it seems nobody has integrated it into
GnuSkin for whatever reason. It seems
JoachimNilsson had intended to release a '2.0' version of the skin with some fixes, but hasn't done so. Currently the skin apparently isn't even designed to work flawlessly with the 01 Feb 2003 release, much less the upcoming
CairoRelease.
Don't worry too much about it - it's no big deal. This time I'm going to put a link to this topic in
GnuSkinPluginDev for you; in the future you'll know the 'right thing' to do.
--
WalterMundt - 18 Feb 2004