Bug: Call to TWiki::Func::getPluginPreferencesFlag returns wrong value

When a plugin calls TWiki::Func::getPluginPerferencesFlag( "DEBUG" ) it will allways return 0 regardless of whether * Set DEBUG = 1 is set in the NewPlugin page.

Test case

Set DEBUG = 1 in NewPlugin page.

in NewPlugin::initPlugin have
$debug = TWiki::Func::getPluginPreferencesFlag( "DEBUG" );
TWiki::Func::writeDebug( "- TWiki::Plugins::${pluginName}::initPlugin(DEBUG: $debug )" );

do some action in TWiki

in data/debug.txt should see
21 Jun 2005 - 10:39 - TWiki::Plugins::SecurePubPlugin::initPlugin(DEBUG: 1 )
actually see
21 Jun 2005 - 10:39 - TWiki::Plugins::SecurePubPlugin::initPlugin(DEBUG: 0 )

Environment

-- CharlesDupont - 21 Jun 2005

Impact and Available Solutions

Follow up

Fix record

--- lib/TWiki/Func.pm   2005-06-21 11:03:57.000000000 -0500
+++ lib/TWiki/Func.pm   2005-06-21 11:10:31.000000000 -0500
@@ -407,8 +407,9 @@
 sub getPluginPreferencesFlag
 {
     my( $theKey ) = @_;
-    my $value = getPluginPreferencesValue( $theKey );
-    return TWiki::Prefs::formatAsFlag($value);
+    my $package = caller;
+    $package =~ s/.*:://; # strip off TWiki::Plugins:: prefix
+    return TWiki::Prefs::getPreferencesFlag( "\U$package\E_$theKey" );
 }

 # =========================

-- CharlesDupont - 21 Jun 2005

Discussion

See also GetPluginPreferencesFlagDoesNotWork, GetPluginPreferencesValueBroken, and GetPluginPreferencesFlagDoesNotWorkInMyPlugin

-- CrawfordCurrie - 22 Jun 2005