Bug: Attachment Comment Bug

A user reported the following error when attempting to upload an attachment. By changing their comment from Webb ECR to Webb, the upload became possible.

During save of file Software.SpacewayCORBACMDServerSDF an error was found by the version control system. Please notify your TWiki administrator. 

/usr/local/bin/ci -q -l -m''Webb ECR'' -t-none -w'SusanDenning'
/usr/local/apache/htdocs/twiki/pub/Software/SpacewayCORBACMDServerSDF/ECR4748.pdf 2>&1 1>/dev/null
ci: ECR,v: Permission denied
ci: -t-none option is ignored after pathnames
ci: -wSusanDenning option is ignored after pathnames

Go back in your browser and save your changes locally.

Test case

Environment

-- MartyBacke - 15 Aug 2002

Follow up

I'll bet this is the Unix version of QuotesInAttachCommentError. The root cause is discussed in SearchFailsIfSingleQuoteIncluded. The problem is related to improper quoting of user data passed to external programs. Note the doubled single quotes in the example. I wonder if she entered 'Webb ECR' and not Webb ECR.

Also my guess is when she reentered the comment with Webb she left off the quotes since there was no space in the comment to quote. If she didn't enter quotes then then there is something wrong with that TWiki installation that is requoting text.

-- JohnRouillard - 15 Aug 2002

After reading your comment I asked the user, and she said no quotes of any kind were used

-- MartyBacke - 16 Aug 2002

Sigh, no single quotes huh? Have you tried uploading another file with a two word comment? Does that work correctly? Can the user reproduce the bug at will? Can you get the user to try reproducing the bug on a sandbox topic on twiki.org?

-- JohnRouillard - 17 Aug 2002

I have since duplicated the error, and it only occurs with single quotes (as you correctly stately earlier). I now conclude that the user wasn't aware that she used single quotes when I asked her.

Thanks for the help

-- MartyBacke - 19 Aug 2002

Fix record