Question

Using Edit table plugin like this;

%EDITTABLE(header="on" format="|text,10|textarea,3x70|select,1,%UNKNOWN%,%STABLE%,%BUG%|% quietsave="on" changerows="on")%

I can only create 7 rows of data. When I try and create the 8th row, the browser hangs. I get the same response with either firefox or IE. I created a table with more than 7 rows and the browser hangs trying to edit it.

I've added some comments to EditTablePluginDev.

If I don't use the select drop down list, it works without a problem. However, the drop down list makes it real nice and I'd like to get it to work.

I'm not sure where to look for a solution.

Thanks.

-- PeterWhiting - 21 Mar 2004

Environment

-- PeterWhiting - 21 Mar 2004

Answer

Works great, doesn't it? Can't reproduce your error, so I can't help, sorry.

-- FranzJosefSilli - 24 Mar 2004

I guess it must be some problem with our apache setup. Thanks for taking the time to try it on your system.

-- PeterWhiting - 25 Mar 2004

I have never seen that on the TWiki installations I manage but I have had reports like this before. At work we use up to 100 table rows.

Not sure where too look. Except that this Plugin is eating a lot of CPU cycles on the server when adding rows. Run top to find out.

-- PeterThoeny - 27 Mar 2004

I have the same problem (I'm using Windows XP, Apache 1.3.28, and Cygwin 5.6.1-2). If I put a combo box, or a calender in the table, adding the 8th row hangs. If I put both in the table I can only add three rows successfully.

-- JoelOnofrio - 20 Apr 2004

I have also seen this problem on both my linux server and Windows XP. On the linux server it seemed to be a problem with the expandCommonVariables function calls in EditTablePlugin.pm. I commented these out and everything seemed to work fine. I tried the same on my Windows XP system but this doesn't seem to fix it.

It looks like expandCommonVariables was getting into some huge recursive loop (I think it actually would finish it if you gave it like 20 minutes or something). I'll check what the problem is on Windows XP and give an update later

-- RyanPrichard - 27 Apr 2004

Ok, found it, on line 545 of EditTablePlugin.pm the call to expandCommonVariables causes a call to commonTagsHandler which produces an html header. This is called every time a select tag is seen, cauing another header. The web server eventually kills off the program for too many headers.

All I did was to drop the call to expandCommonVariables: #my $expandedValue = &TWiki::Func::expandCommonVariables( $theValue, $theTopic, $theWeb ); my $expandedValue = $theValue;

-- DavidSmith - 27 Apr 2004

David, I tried just commenting out the line 545 and the problem still existed on my XP server. So I went ahead and commented out all calls to expandCommonVariables (I think there were 2 more) as Ryan stated and it is now working fine. Thanks for the help!

-- JoelOnofrio - 27 Apr 2004

This fix however breaks existing functionality (you might not need)

-- PeterThoeny - 28 Apr 2004