Development discussion for OoProjectPlannerPlugin

-- AndrewBarber - 15 Nov 2005

Thanks Andrew for contributing this Plugin to the TWikiCommunity! We get some many Plugins

I made some changes (view raw) to the Plugin topic, feel free to roll it back into the next release:

• Don't link to itself
• Use %TWIKIWEB% instead of TWiki
• Descriptive SHORTDESCRIPTION
• Removed DEBUG flag
• Added TOC and shifted heading levels
• Use Interwiki links
• Added some items to Plugin Info table
• For %SOMETHING% use term "variable" instead of "tag"

Some suggestions:

• The ProjectTemplate and PlanTemplate topics are referenced, but they are not in the ZIP. Is this intentional?
• Variable definition: Many variables have a perfomance impact. It might be cleaner to define just one variable %OOPP{}% and define an action with optional parameters, e.g.
  • %OOPP{ action="allprojects" }%
  • %OOPP{ action="allplans" }%
  • %OOPP{ action="allprojectsplans" project="BarProject" }%
  • %OOPP{ action="allprojectstasks" project="BarProject,FooProject" }%
  • %OOPP{ action="querysummary" project="BarProject" plan="FooPlan,BarPlan" where="Module=~dirtest&&Developer=~unassigned" groupby="Priority" }%
  • Note: It is easy to extract the parmeters with TWiki::Func::extractNameValuePair( )
• For OOPPQUERYSUMMARY and OOPPQUERYDETAILS, the ":" separator is unusual for TWiki. Could be done with named parameters
• Add example to how variables can be used, e.g. "comma separated list of planexp:taskexp regex pairs" alone is not so descriptive
• How about measuring and documenting the PluginBenchmarks?
• Consider rearranging content: User doc and examples first, followed by settings, installation instructions and plugin info last

-- PeterThoeny - 16 Nov 2005

Thanks for the comments. Since my only exposure to creating twiki plugins was from rewriting the original plugin, I continued the bad habits

There is alot more cleanup to be done in the documentation I see. I'll try and get to it over time. I'll start by adding the new variable form with named parameters, however, due to backwards compatability issues, the old variables will have to stay for some time.

I should probably add the templates, but they are used in a per web basis, so having them in the TWiki web would just serve as an example (which is probably a good thing to have).

I believe I rolled your topic changes back into the release when I first noticed you made the changes.

I don't know how you find the time to look after so many plugins

-- AndrewBarber - 29 Nov 2005

I have attempted to install this plugin on the newest version of TWiki, with the template files from the ProjectPlannerPlugin.2.040 package, since none were included with this distro.

One problem that I am having, and I am not a perl guy, is the following error:

Can't use string ("PROJECTPLANNERPLUGIN_EXAMPLE") as a HASH ref while "strict refs" in use at /var/www/html/twiki/lib/TWiki/Prefs.pm line 218.

Suggestions, fixes?

Any help is appreciated.

Thanks.

-- JeffStrahl - 03 Mar 2006

To the Plugin maintainer: This Plugin does not work in TWiki 4.0 because it uses undocumented functions. Please consider upgrading this Plugin so that it runs on Cairo and Dakar codebase as described in HandlingCairoDakarPluginDifferences.

-- PeterThoeny - 04 Mar 2006

Hmmm, I'll look into the perl error and the undocumented functions parts. Sorry I don't read this forum more often. Real work gets in the way

-- AndrewBarber - 11 May 2006

I got this same error when installing ActionTracker plugin. I've removed it, but the whole Twiki will not come up because of this error. I'm very new to Twiki and could really use any help you would be willing to give. Thank you!

-- RobinWebber - 20 Sep 2007

Plugin now updated for 4.0.

-- AndrewBarber - 02 Jan 2008

In the case of invalid input parameters, the function ppSavePage of this plugin makes several calls to TWiki::redirect( $query, $url), where $query is a CGI object, whereas TWiki::redirect expects a TWiki object as first argument. This results in error messages like Can't call method "redirectCgiQueryHandler" on an undefined value at TWiki.pm line 725.

Probably you wanted to call TWiki::Func::redirectCgiQuery( $query, $url) instead ?

-- JChristophFuchs - 22 Jan 2008