Bug: Uploading or saving a pages hanging forever and tons of error in Apache error log

After upgrading a Cairo to the TWikiBetaRelease2004x10x24 people started reporting trouble with uploading files and saving topics.

Inspection of the log showed a pretty good hint of the problem. I had in two days got 300 MB of the same error message.

view: Use of uninitialized value in hash element at /usr/local/apache2/twiki/lib/TWiki/Prefs.pm line 413

Prefs.pm is one of the files updated with the beta. Reverting to the Cairo version removed the problem

I first shouted for help at the #twiki channel on Freenode IRC and an amazing 4-6 people jumped on it and fixed the problem in 30 minutes. You try reporting a bug like this with a Microsoft product and see how fast you get a fix

I have put the fix below. The code should already be on the DEVELOP branch on SVN. I report it here so that people that download the beta can do the fix manually. And to make sure it goes from the DEVELOP branch to the main branch.

Test case

Normal use of TWIki with uploading and saving both with IE and Firefox.

Environment

-- KennethLavrsen - 28 Oct 2004

Follow up

Fix record

In ...lib/TWiki/Prefs.pm line 412 change the current line from

foreach my $key( %{$otherPrefsObject->{prefs}} ) {

to

foreach my $key( keys(%{$otherPrefsObject->{prefs}})) {

Thanks to the gang on IRC for help. #twiki on IRC is a great place to hang around.

-- KennethLavrsen - 28 Oct 2004

Thanks Kenneth for posting.

The fix is now in SVN MAIN, ready for the next TWikiBetaRelease2004x10x30

(To save time I will use MAIN until the pending issues of LocationLocationLocation are resolved)

-- PeterThoeny - 30 Oct 2004