Tags:
create new tag
view all tags

Refactoring Proposal: TWiki::VERSION makes TWiki Perl package compliant

I added a $TWiki::VERSION string to return the Subversion checkin string. This is because Packagename::VERSION is the standard Perl/CPAN convention and because Crawford agreed its a good idea.

Committed to 3438. I trust someone will say if they disgree.

-- MartinCleaver - 10 Jan 2005

Not a bad idea but I hope you will fix SVNget:bin/testenv - that's probably the only place that uses $wikiversion.

testenv is now fixed in SVN DevelopBranch, and will still work with old versions of TWiki.pm, which is a requirement so anyone can download latest testenv for installation debugging purposes (see comments at top of testenv).

-- RichardDonkin - 10 Jan 2005

Good idea to introduce the standard $TWiki::VERSION.

Ehem, but the $wikiversion is gone? The date string needs to be restored / or combined into $VERSION. All TWiki documentation is standardized on "DD Mon YYYY" release strings, and I do not intend to change that. This date string is not necessarily the date of the last checkin. Think of the date string representing the officially communicated release for end users, and the SVN version number as the internal build number (also used by end users to report bugs)

-- PeterThoeny - 12 Jan 2005

The date string was combined into $VERSION as $LastChangedDate$, as described in the subversion documentation, but for some reason it's not working..... investigating

... later.... OK, I enabled the right property. The $VERSION looks like this:

$VERSION = ' $Date: 2005/01/31 19:35:59 $ $Rev: 3476 $';
This will be reported by WIKIVERSION. If you want, it would be easy enough to add some code to clean it up, but personally I think it's just fine (it includes the date in the format you require).

It would be really nice to have this automatically updated whenever a file is checked in, but we haven't worked out how to do that yet. Anyone got any ideas? (Sven is dead set against the idea of a trigger script that checks in a new TWiki.pm every time there is a change)

-- CrawfordCurrie - 12 Jan 2005

Actually, WIKIVERSIOn just reports the date and rev, so it's even more like what Peter wants. Still need ideas on how we can get the string updated to reflect the current state of the repository, though.

-- CrawfordCurrie - 24 Jan 2005

ChangeProposalForm
TopicClassification CodeRefactor
TopicSummary Introduce TWiki::VERSION to make TWiki Perl package compliant
CurrentState ReadyForMerge
OutstandingIssues How to combine with TWiki release string standard
RelatedTopics

InterestedParties

ProposedFor DakarRelease
TWikiContributors

Edit | Attach | Watch | Print version | History: r13 < r12 < r11 < r10 < r9 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r13 - 2005-01-31 - SamHasler
 
  • Learn about TWiki  
  • Download TWiki
This site is powered by the TWiki collaboration platform Powered by Perl Hosted by OICcam.com Ideas, requests, problems regarding TWiki? Send feedback. Ask community in the support forum.
Copyright © 1999-2026 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.