e.g. to allow
SpacedWikiWordPlugin to work without the hack.
Patches are for the renderWikiWordHandler, but as the anonymous CVS repository does not refresh quickly enough I can't disentangle todays patches from yesterdays. It shouldn't matter - but they contain 1.022 (
BeforeAttachmentSaveHandler) as well.
Looks like a decent idea, but I'm slightly reluctant to add new plugin handlers without a bit of discussion, since a change in the public API is difficult to undo if it turns out to be a bad idea. Anyone else (
CoreTeam or no) care to weigh in?
--
WalterMundt - 20 Apr 2004
As
MartinCleaver said in
PatchProposal, we've seen no activity here. I was hoping for someone to make a comment or two, either for or against, but in the absence of input I'm going to go ahead and put this in.
--
WalterMundt - 28 Apr 2004
There. Committed.
--
WalterMundt - 28 Apr 2004
Thanks Walter
--
MartinCleaver - 28 Apr 2004
Martin - you need to provide docco for the parameters and return of this one too
--
SvenDowideit - 19 Jul 2004
I'm happy to provide this, but I'm unclear of what documentation is needed for handlers.
BeforeCommonTagsHandler doesn't seem to have any yet, beyond what is in
MorePluginHooks and my Handlers are already in that.
Furthermore, we need a way to tag Patches as needing documentation, save they get lost in the codev maelstrom.
--
MartinCleaver - 19 Jul 2004
Martin - use the pod eg (I added then to the svn version of Plugins.pm yesrerday), but basically just fill in parameters and resturns and the description as in
UserDotPm. either in this topic, or as apatch. I simply don't know what the answers are, otherwise I would have done it.
on patches, i don't agree, as I don't accept patches without docco anymore, infoact it is part of the Patches procedure for the patch to be supplied with docco, or to be set at adjustment needed. this way there areonly a few patches that slipped through that need fixing (and they have docco set to less than 100%)
--
SvenDowideit - 19 Jul 2004
I second Sven's request. Good patches should include docs, this makes it easier for us to include them faster.
At this time, Plugin callbacks are documented just in the code. For each new handler (or change in handler),
PluginsDotPm,
EmptyPluginDotPm and
DefaultPluginDotPm need to be updated. As an example, see recent documentation in code of
BeforeCommonTagsHandler.
--
PeterThoeny - 20 Jul 2004
This doc is still pending.
--
PeterThoeny - 16 Aug 2004