Tags:
create new tag
view all tags

Bug: rdiff not rdiffauth when viewauth used

When viewing topics through viewauth the links for the diffs (eg 1.7 > 1.5 > 1.4, i'm talking about the > links now) are to rdiff, not rdiffauth, causing clicking on the link showing 'oops, no xx' error.

It seems this has to do with the templates, where a %SCRIPTSUFFIX% tag is defined, but not filled apparently.. Although simply putting 'auth' in that tag won't do either since then it will also link to 'attachauth' etc which does not exits.

Test case

Set up a wiki that can only be viewed by logged in users (eg ALLOWWEBVIEW=Main.MeOnly). Log in, load a page that has been editted and click the diff links.

Environment

TWiki version: TWikiRelease02Sep2004
TWiki plugins: DefaultPlugin, EmptyPlugin, InterwikiPlugin
Server OS: Freebsd 4.9
Web server: apache 1.3.33
Perl version: 5.8.5
Client OS: linux
Web Browser: firefox

-- KoenMartens - 10 Dec 2004

Follow up

Ok, so not hindered by any knowledge of how the source of TWiki is structured, I fixed it myself. This patch adds a new global tag %AUTH% to the templates, it is replaced by 'auth' if viewauth is used, and by '' if view is used. All rdiff%SCRIPTSUFFIX% instances have been replaced by rdiff%AUTH%%SCRIPTSUFFIX% in the templates.

Probably should check whether rdiffauth is in .htaccess too.

Didn't check whether any of the alpha/beta releases fixes this problem btw (no time atm).

-- KoenMartens - 15 Dec 2004

Fix record

Topic attachments
I Attachment History Action Size Date Who Comment
Unknown file formatpatch authfix.patch r1 manage 17.8 K 2004-12-15 - 20:43 UnknownUser Patch against 20040902 to fix this bug
Edit | Attach | Watch | Print version | History: r2 < r1 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r2 - 2004-12-15 - KoenMartens
 
  • Learn about TWiki  
  • Download TWiki
This site is powered by the TWiki collaboration platform Powered by Perl Hosted by OICcam.com Ideas, requests, problems regarding TWiki? Send feedback. Ask community in the support forum.
Copyright © 1999-2026 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.