Tags:
create new tag
view all tags

Bug: Formatting problem in oopsmore.tmpl

In -r1.7 of oopsmore.tmpl the last list "Compare revisions" is placed in table cells. Twiki starts a new top level list in each cell, leading to the following awkward display:

TWiki.org home TWiki . Know . WebHome (more)
Topic actions

More Actions on Topic WebHome

  • Parent of WebHome:
    • Set topic parent to , then and save the topic to activate the new parent.

  • View previous topic revision:
    • Revision: in raw text format
    • Revisions: 1.1 ... 1.8

  • Compare revisions:
    • Older revision:
    • Newer revision:

Topic WebHome . { Cancel }

The patch below removes the cells around the Older and Newer revision forms, leading to a more pleasing display.

Test case

Environment

TWiki version: Beijing
TWiki plugins: Standard
Server OS: W2K
Web server: Apache
Perl version: 5.6.1
Client OS: W2K
Web Browser: IE5

-- ThomasWeigert - 09 Nov 2002

Follow up

Fix record

Thanks for spotting this and providing a diff. It makes it very easy to roll it into TWikiAlphaRelease. Change is also at TWiki.org. (The change is not perfect since the boxes are not aligned depending on the font, but that does not matter)

-- PeterThoeny - 09 Nov 2002

Yes, I realized the problem with alignment. The way to get these two boxes aligned is to use a table as originally, but apparently the list rendering mechanism starts a new list. Right now I stuck two non-breaking spaces to move the upper box further right, but that is certainly not ideal. I was wondering whether it might not be better to not try to align them at all, and remove the two spaces before the upper box?

I have noticed other things that cause problems with list rendering, e.g., you embed some HTML between. I guess anything that causes a line break is a problem?

Also, what is the difference between TWikiAlphaRelease and something being available on the SourceForge repository? I am asking because this change is not yet on SourceForge....

Topic attachments
I Attachment History Action Size Date Who Comment
Unknown file formatdiff oopsmore.diff r1 manage 1.0 K 2002-11-09 - 15:35 UnknownUser Patch to oopsmore.tmpl -r1.7
Edit | Attach | Watch | Print version | History: r4 < r3 < r2 < r1 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r4 - 2002-11-10 - ThomasWeigert
 
  • Learn about TWiki  
  • Download TWiki
This site is powered by the TWiki collaboration platform Powered by Perl Hosted by OICcam.com Ideas, requests, problems regarding TWiki? Send feedback. Ask community in the support forum.
Copyright © 1999-2026 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.