Bug: Error when trying to remove a lock on a rcs file

In lib/TWiki/Store/RcsWrap.pm , in the sub _ci, there is a variable $cmd in which is stored the commands to be run and it's used for far too many things.

Test case

First, it's assigned the $self->{"ciCmd"} , which is then fiddled with so that the arguments are right, it's then executed.

If the lock was wrongly set, it then put $self->{"breakLockCmd"} in $cmd and executes it, so that there is no more lock to the file.

Then, it executes $cmd again thinking that, well, it still has the first command, but, well, it's a bit not really true, since it's been assigned something else.

The patch of the diff is at http://p.mat.cc/p

-- MathieuArnold - 09 Feb 2005

Environment

-- MathieuArnold - 09 Feb 2005

Follow up

Thanks Matt, this is a known issue and has been fixed, though not retro-fitted to Cairo release. It should not be a problem in future releases.

-- CrawfordCurrie - 10 Feb 2005

Fix record