Bug: File Attachment Version Viewing Bug

When a file attachment has exactly two versions, viewing a version is not possible because only a direct link to the most recent version is provided. Viewing ver 1.1 is always a direct link to the most recent version (wrong).

Test case

Add a simple text file as an attachment to a page, change it once, then view the attachment history - both versions appear the same and are direct links instead of revision links.

A fix is as follows:

in file lib/TWiki/Attach.pm at line 182:

You should see the line:

if ( $topRev || $rev eq "1.1" ) {

please comment it out and add: if ( $topRev ) {

Environment

-- StevePrior - 04 Dec 2004

Follow up

Fix record

this patch has been applied to DEVELOP. i don't know who did it, or when, but it's done.

-- WillNorris - 06 Dec 2004