Bug: Problem in RcsWrap on Dakar

It should be possible to retrieve a previous version of a topic. However, in current Dakar, when RcsWrap is used (on Windows, don't know about other platforms) an empty string is returned instead. (RcsLite does not have this problem).

Test case

Just go back to any older version.

Environment

-- ThomasWeigert - 30 Apr 2005

Impact and Available Solutions

Follow up

oh, Thomas, I think you will find that if you use Cairo with the same rcs on windows that it is also busted - If not, please compare the command line parameters in your TWiki.cfg / LocalSite.cfg

the other thing you'll need to do is to play around on the command line until rcs gives you the old version - there are a number of funnies that have meant that whenever i was in a rush I used RcsLite (and thats the reason i fixed so many of the bugs in it previously)

-- SvenDowideit - 30 Apr 2005

Let me understand what you are saying... RcsWrap has not been working on windows even in Cairo?

-- ThomasWeigert - 01 May 2005

I just checked...

• at least this aspect works fine in windows on Cairo
• checking a file out on the command line works when using exactly the options defined in TWiki.cfg

-- ThomasWeigert - 01 May 2005

I found the problem. It had to do with that now we mark shell calls with special endings, in this particular case %REVISION|N%.

However, I also discovered that there is a bunch of code there that supposedly supports windows but is not needed on my window system (using cygwin). This code copies the file to a temporary location and checks it out there and then reads from the temp file and then deletes them. I commented that code out. Maybe somebody else can check on their window system, but it works for me.

-- ThomasWeigert - 01 May 2005

I'm guessing its because that code is needed when you run twiki without cygwin - which is what I used to do (i have not used windows for twiki for a while though)

-- SvenDowideit - 01 May 2005

Do you know who wrote this code? We probably should include it conditionally based on a setting in LocalSite.cfg

-- ThomasWeigert - 01 May 2005

Done. The option $cfg{RCS}{coMustCopy} can be set in the config file to force the alternative behavior, if needed.

-- ThomasWeigert - 02 May 2005

cool i'm still hoping that we'll get non-cygwin working again, thanks

the code could have been written by any number of people - its damned old (i'm not sure if it pre-dated John's re-write of store or not)

-- SvenDowideit - 02 May 2005

The old functionality works also. So if your RCS worked on Cairo, it should now work again, after the fixes below. I also added a flag to allow to not use the special code when it is not needed.

-- ThomasWeigert - 02 May 2005

Fix record

Fixed as 4218 and 4219 (conditionalization of window-specific behavior through TWiki.cfg).

Discussion