TwistyPlugin does not work after upgrading

Question

I just installed a new wiki server with TWiki 4.0.4 with a few additional plugins. I noticed that the twisty plugin is not working correctly. Any code that uses TwistyContrib directly seems to be fine, but TwistyPlugin is broken. I tried setting the debug option to 1 and that did not even work (the plugin is enabled in configure). I did a tail on the apache error log and noticed this message

File does not exist: /var/www/twiki/pub/TWiki/BehaviourContrib, referer: http://wiki.domain.com/bin/view/TWiki/TwistyPlugin

I then did a grep through the TwistyPlugin files for " ehaviour " and found that the TwistyPlugin.pm has this line:

<script type="text/javascript" src="%PUBURL%/%TWIKIWEB%/BehaviourContrib/behaviour.js"></script>

Any ideas or insights from others? Thanks,

Environment

-- RobLeach - 23 Oct 2006

Answer

Update: please use one of the upgrade bundles in UpgradingTwisty.

-- ArthurClemens - 19 Nov 2007

The testing RobLeach performed:

Okay, I've done some further testing by installing fresh installs of both TWiki-4.0.4 and TWiki-4.0.5 on my server.

1. Installed TWiki-4.0.5
2. setup the software based on the install documentation
   1. copy and modify lib/LocalSite.cfg and bin/LocalLib.cfg
   2. configure the server
3. I did not install any additional plugin or contrib packages (pristine install)
4. Registered myself and added an attachment to my User Page
5. The attachment table did not work correctly (in Firefox on Ubuntu)
6. Loaded the TWiki server in IE on a windows box and the attachment table worked fine.
7. Loaded the TWiki server in Mozilla on my Ubuntu box and the attachment table worked fine.
8. Blew away the TWiki server
9. Installed TWiki-4.0.4
10. setup the software based on the install documentation
    1. copy and modify lib/LocalSite.cfg and bin/LocalLib.cfg
    2. configure the server
11. I did not install any additional plugin or contrib packages (pristine install)
12. Registered myself and added an attachment to my User page
13. The attachment table did not work correctly (in Firefox on Ubuntu)
14. Loaded the TWiki server in IE on a windows box and the attachment table worked fine.
15. Loaded the TWiki server in Mozilla on my Ubuntu box and the attachment table worked fine.
16. Blew away that TWiki server
17. Put back the original server that I've been toubleshooting for a week (TWiki-4.0.4 with hotfix 4, and many added plugins including the TwistyContrib, BehaviourContrib and TwistyPlugin packages).
18. Loaded the TWiki server in Firefox on my Ubuntu box, the attachment table did not work.
19. Loaded the TWiki server in IE on a windows box and the attachment table did not work.
20. Loaded the TWiki server in Mozilla on my Ubuntu box and the attachment table did not work.

So it looks like there are a number of issues going on here that seem to be interplaying with each other. First, Firefox is doing the wrong thing regarding the TwistyContrib package (I did verify that Firefox had javascript enabled and no features were turned off). Second, the installation that I have of TWiki-4.0.4 with hotfix 4 and additional plugin packages installed, twisty is broken. I'm open to suggestions, perhaps I did something that broke my install.

-- RobLeach - 26 Oct 2006

I can add another confirmation that after installing the new twiki.js file into pub/TWiki/TWikiJavascripts/ the twisty's appear to be working correctly (for Firefox and IE). Mozilla is still exhibiting bad behaviour though (it displays both show and hide text and the page is still refreshed with a # symbol in the URL).

-- RobLeach - 07 Nov 2006

I have updated the pattern skin update package and refactored the QAs above.

-- ArthurClemens - 07 Nov 2006

I just installed the latest PatternSkin update and twisty's work fine in all browsers, with the minor exception that Mozilla still refreshes the page and appends a # to the URL (but Mozilla no longer shows both the hide and show text on initial page load). Great job!

-- RobLeach - 08 Nov 2006

I found another problem....
When I edit any page, the small help dialog section at the top of the edit window is expanded on the initial page load and both the show and hide text is visible. When I click in the show/hide twisty text to shrink the help section, the page is forcibly reloaded and there is a # symbol in the URL and I'm no longer editing the page. This seems to be a more critical symptom of the twisty issues than previously mentioned.

-- RobLeach - 09 Nov 2006

This problem is exhibited in all browsers.

-- RobLeach - 09 Nov 2006

I can confirm this. Hold on, and sorry for the hassle.

-- ArthurClemens - 09 Nov 2006

Every time I see more little changes that have been done to PatternSkin. I have uploaded a new updater with found files. No guarantees, but it should work better now.

-- ArthurClemens - 09 Nov 2006

No problem Arthur, we'll get there in the end and it will be better for all. I'll grab the new PatternSkin and test it out in a minute....

-- RobLeach - 09 Nov 2006

Hmm..., I need to confirm that I installed the correct updated package. I grabbed PatternSkinUpdate2006x11x09.zip from the PatternSkin plugin page. After unpacking this package in the root of the TWiki directory and performing the necessary file permission/ownership changes I tried it out in Mozilla/Firefox/IE and all exhibited the exact same problem. If I grabbed the wrong updated package then point me at the correct one, otherwise it looks like there is still a problem with the above described issue (behaviour wise at least).

-- RobLeach - 09 Nov 2006

Aargh. Somehow I forgot to include edit.pattern.tmpl. Please try again, I have updated the download link.

-- ArthurClemens - 09 Nov 2006

I was able to grab the updated package today and install it on the server. The update worked great, with the exception of Mozilla still exhibiting minor problems (described above). Good job Arthur, just let me know if I can help out with this any further.

-- RobLeach - 13 Nov 2006

I am curious why Mozilla shows these problems. I must say I only have tested Firefox on Windows and Mac, not Mozilla.

-- ArthurClemens - 13 Nov 2006

Yeah, I wouldn't be too concerned myself but there are a few developers we have in house that use Mozilla over Firefox (personal choice I guess). But to be clear, it's really not critical.

I ran a few tests with the JavaScript Console and nothing was logged when using any twisty. I then fired up the JavaScript Debugger, but without knowing what to look for I was not able to see anything out of the ordinary. Is there any particular function that I should watch during use of a twisty? This might not be useful but I thought I'd offer. The other thing to note (at least it seems strange to me), the malformed URL (containing the # at the end) is in the HTML doc when the page loads, so this would indicate that it's has already been processed before any action from the user takes place.

-- RobLeach - 13 Nov 2006

If you want to upgrade TwistyPlugin - or have upgraded already - please see UpgradingTwisty for an easy bundle upgrade package.

-- ArthurClemens - 19 Nov 2007