Tags:
create new tag
view all tags

Question

TreePlugin, the 0.310 alpha version of January 2003

Many situations cause pages not to appear in the tree listing.

These include:

  • circular parent pointers
  • parents in different webs
  • parent does not exist

These need to be fixed.

Also, an enhancement request: want to be able to set a page to have no parent.

  • TWiki version: (TWiki version: 01 Feb 2003)
  • Perl version: 5.6.1
  • Web server & version: Apache
  • Server OS: SunOS? + Linux
  • Web browser & version: Internet Explorer 6.0
  • Client OS: Windows XP

-- AndyGlew - 15 Apr 2003

Answer

Regarding topic parent, a woraround is to set it to WebHome.

-- PeterThoeny - 29 May 2003

That's basically what I do - the problem is that you have to know that the page is missing from TreePlugin's listing before you can go to fix it, and that requires (manually) comparing the TopicList and the tree listing.

-- AndyGlew - 02 Jun 2003

I have fixed many, if not all, of the bugs reported here:

  • circular parent pointers
  • parents in different webs
  • parent does not exist
I have not worked on the improved parent editing.

I am a bit too tired to check this in tonight; I'll do it tomorrow after some cleanup. Hmmm... I can't check in, since my company does not allow CVS across the firewall. I'll post the fixes.

Longer term, need to improve aspects of TreePlugin, such as being able to figure out an order for the children that is not alphabetical.

-- AndyGlew - 03 Jul 2003

Here are the changes I have made to TreePlugin to fix this bug. I am attaching both a patch, and a gzip'ed whole distribution.

Unfortunately, there are two fixes in this patch:

GOOD
the fix that makes TreePlugin handle pages with funny parentage,
  1. e. that makes TreePlugin no longer lose pages (at least in my tests, both automated (added to the test suite) and manual at my site.
SUSPECT
the fixes that make TreePlugin print non-wiki-word links. This fix is suspect, because it simply adds double brackets around all topic names; works fine for the text formats, but breaks some of the fancier formats. As reported elsewhere, a proper fix would "split" name printing.
I really should separate these two fixes into two different patches, but I am running for a plane. Maybe after I get back.

The patch and the patched tar.gz differ slightly, in that in the latter I removed the twiki/lib/TWiki/Plugins/TreePlugin/test.tar.gz file, since it was redundant with twiki/lib/TWiki/Plugins/TreePlugin/test unpacked directory.

I regret to admit that I toook some shortcuts with the test; basically, the existing unit tests are not really unit tests, in that they are not freestanding and cannot interoperate with other tests of their same type. So I just cut and pasted from PluginTest.pm to PluginTest2.pm. Meant to refactor, but could not get to work, probably because PluginTest.pm still has some global dependencies that I did not find and make object specific. There's a comment in PluginTest2.pm about this.

-- AndyGlew - 04 Jul 2003

Hi,

I was thinking about one tool like this... and luckily I have found out someone has already done the dirty work smile

Contratulations and thank you very much!

I just noticed one litte issue very simple of being solved:

  • When using thread, threadexp, etc views - the ones that use graphics - you are pointing (e.g.) to pub/Plugins/TreePlugin/T.gif, but this file actually is located on pub/TWiki/TreePlugin/T.gif
  • I can solve that by copying the TreePlugin from pub/TWiki to pub/Pluguins, however, I am sure you can verify what is wrong on the code and fix it more adequately wink

-- AndreDantas - 17 Jul 2003

Refactored out off topic comments from revision 1.14

Also, SettingParentTopicToNone feature is now in TWikiAlphaRelease and at TWiki.org.

-- SamHasler - 25 Nov 2003

Topic attachments
I Attachment History Action Size Date Who Comment
Unknown file formatpatch TreePlugin.patch r1 manage 78.6 K 2003-07-04 - 02:29 UnknownUser patch (diff -uNr) for <np>TreePlugin 310
Unknown file formatgz TreePlugin.patched.tar.gz r1 manage 40.9 K 2003-07-04 - 02:32 UnknownUser Patched (removed test.tar.gz)
Edit | Attach | Watch | Print version | History: r16 < r15 < r14 < r13 < r12 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r16 - 2004-02-01 - PeterThoeny
 
  • Learn about TWiki  
  • Download TWiki
This site is powered by the TWiki collaboration platform Powered by Perl Hosted by OICcam.com Ideas, requests, problems regarding TWiki? Send feedback. Ask community in the support forum.
Copyright © 1999-2026 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.