SID-00855: Open ID login has broken HTML

Status:	Answered	TWiki version:	4.3.2	Perl version:	5.10.0
Category:	OpenIdRpContrib	Server OS:	Ubuntu 9.10, 64-bit	Last update:	16 years ago

Hi al!

I installed the OpenID plugin and end up with a front page with a broken login box in the upper left of the page:

• OpenIdRpContrib - (added by PTh)

http://skitch.com/capttofu/dgkan/webhome-main-twiki

I've dug around in the code, but cannot figure out where this broken html is coming from. The closing form tag is missing and the html > and < are displayed as entities vs. rednering.

Any help in this would be greatly appreciated!

Thanks - and double thanks for using Perl for cool project!

-- PatrickGalbraith - 2010-06-02

Discussion and Answer

Which OpenID integration do you use? I suggest to use the latest OpenIdRpContrib.

-- PeterThoeny - 2010-06-02

Hi there - any news from anyone? I dug into the template where this problem arises:

openidlogin.tmp

%TMPL:DEF{"sidebarlogin"}%
%MAKETEXT{"Login via [[%SYSTEMWEB%.OpenIdRpContrib][OpenID]]"}%: <form action="%LOGINURL%"  name=
"loginform" method="post">
%OPENIDPROVIDERS{ sidebar="1" }%
%BR%
or
%BR%
%MAKETEXT{"Username"}%:
%TMPL:P{"usernamefield"}%
<!-- password field -->
%MAKETEXT{"Password"}%:
%TMPL:P{"passwordfield"}%
<!-- end password field -->
%BR%
%TMPL:P{"submit"}%
</form>
%TMPL:END%

The comments, I added. What the HTML ends up as is this:

<div class="patternLeftBarPersonal">
<ul><li class="patternLogIn">
Login via <a href="/bin/view/TWiki/OpenIdRpContrib" class="twikiLink">OpenID</a>: <form action="/bin/login/Main/WebHome?origurl=/bin/view"  name="loginform" method="post">
<div class="sidebar_OP_list"></div>

<br /> 
or
<br /> 
Username:
<input class="twikiInputField" type="text" size="60" name="username" value="" /><input type="hidden" name="origurl" value="%ORIGURL%" />
<!-- password field -->
Password:
<input tabindex=
</div><!--/patternLeftBarPersonal-->

The form tag is never closed, and the password form element has a < instead of an actual html tag <input tabindex...>

I tried a bunch of things:

1. put actual html for the password element after "Password". Same error
2. Moved username element right after Password:, that worked, no issues
3. put <p>test</p>, that worked
4. copied the exact HTML for username element below Password, same error

How might I debug this? How might I turn on logging for template parsing?

If any of you attempt to use this plugin, what result do you get?

Any tips would be greatly appreciated! We are trying to go live on this site and the team is all worried now.

regards,

Patrick

-- PatrickGalbraith - 2010-06-08

OK, so it is the OpenIdRpContrib. Hopefully someone can help.

-- PeterThoeny - 2010-06-08

I have a fix for this that works quite satisfactorily:

%TMPL:DEF{"sidebarlogin"}% <a href="/bin/login/Main/WebHome?origurl=/bin/view">Log In</a> %TMPL:END%

instead of the password and username input form elements. This works great and the plugin works great!

-- PatrickGalbraith - 2010-06-08

Yes - this is problematic for WebTopMenu

I use this:-

%TMPL:DEF{"sidebarlogin"}%<a href="%TOPICURL%?origurl=/bin/view">Log In</a>%TMPL:END%

-- MatWitts - 2010-07-10

If you answer a question - or someone answered one of your questions - please remember to edit the page and set the status to answered. The status selector is below the edit box.