Feedback on JSPopupPlugin

-- SvenDowideit - 07 May 2006

Inspiration: http://blogus.xilinus.com/pages/javawin with advanced pop-up windows.

Question: What is the fallback if javascript is off?

As a next step it would be nice to serve dynamic content to a given html element on the page:

• a div/span with id
• "after": create a div/span after a given html element
• "before": create a div/span before a given html element

-- ArthurClemens - 07 May 2006

Arthur, can you give a few use cases? Actually, I've done an experiment like this, and the increase in server load due to TWiki's architecture make sending down sections of a topic, and then assembly on the browser side very very undesirable at the moment.

• Undesirable for the user or for the system? It's quite commmon now to see a circular "progress" animation to indicate loading. In most cases you want editing to take place in the page itself, not in a popup window. -- ArthurClemens - 08 May 2006

WRT fallback for non-javascript, can you give me some advise? what would you expect to happen? I presume that for the rest/delayed eval ones, it becomes a normal link, and for the popup TML, its in page, but once i get going, i'm not sure if this will hold.

• Right, a popup will lead to a normal page with no js. Other kinds of interaction need to be looked at per case. -- ArthurClemens - 08 May 2006

Importantly, the Plugin perl code needs to know if the browser is running JS, so that it can output different HTML - so we really could do with more advanced browser detection and skin code.

• You can place an alternative call in <noscript> -- ArthurClemens - 08 May 2006

-- SvenDowideit - 08 May 2006

Hi, the plugin topic references DojoToolkitContrib and InlineEditPlugin, who both don't seem to exist on twiki.org.

I imagine those being available on SVN? Will they be published soon (ie should I wait?)

-- JosMaccabiani - 17 May 2006

new update to use YahooUserInterfaceContrib more, and updating the DEPENDANCIES listed in the topic - they were in other places in the package, and i missed that.

Dojo and inlineEdit are in svn only, mostly because i'm making fundamental changes every time i touch InlineEdit, and it currently loses any xml tags in your topic source. I've been working on browser support (mosly Safari), but the xml tags are the last major change needed before i publish it.. (though the look and feel need work too)

-- SvenDowideit - 08 Nov 2006

When upgrading to the newest YUI (version 2.5.2) this plugin stops working for popups that load content from a url. Took me a while to figure out that the YUI js needed to be loaded in a different order. This is fixed by editing ./templates/jspopupplugin.javascript.tmpl:

<script language="JavaScript" type="text/javascript" src="%PLUGINPUBURL%/json.js"></script>
<script language="JavaScript" type="text/javascript" src="%PUBURL%/TWiki/YahooUserInterfaceContrib/build/yahoo/yahoo-min.js"></script>
<script language="JavaScript" type="text/javascript" src="%PUBURL%/TWiki/YahooUserInterfaceContrib/build/event/event-min.js"></script>
<script language="JavaScript" type="text/javascript" src="%PUBURL%/TWiki/YahooUserInterfaceContrib/build/connection/connection-min.js"></script>
<script language="JavaScript" type="text/javascript" src="%PUBURL%/TWiki/YahooUserInterfaceContrib/build/dom/dom-min.js"></script>
...

I haven't really explored why this is, but with the original order the scripts were loaded, javascript errors showed up during initialization. Why use 2.5.2? For me, this fixed a few issues, e.g. the popup windows weren't being resized correctly, and JSCalendar within a popup didn't work correctly. Of course, a YUI calendar plugin would be nice as well...

-- AminShehata - 16 Jun 2008

nice catch Amin - I was just wondering about upgrading YahooUIContrib, even though I've pretty much switched to dojo.

-- SvenDowideit - 16 Jun 2008

Can someone provide addition information about "CPAN Dependency: JSON". What is the dependency? What doesn't work if JSON isn't installed?

-- VickiBrown - 28 Jul 2008

I have no idea why JSON is listed as a dependancy. removing it now..

Amin thanks for the fix - its in the version i just uploaded too.

-- SvenDowideit - 16 Aug 2008

Happy to have this, but I found that this caused havoc on my TWiki 4.3.1 JQueryPlugin (particularly with tabs, which are very popular on my site). So, based on what I see above, I removed the json.js inclusion from templates/jspopupplugin.javascript.tmpl, and have not seen any negative fallout yet (although the JSPopupPlugin is very new here).

-- AaronLWalker - 2010-12-08

I think we should convert this plugin to use the JQueryPlugin instead of the YahooUserInterfaceContrib because TWiki standardized on the former JavaScript library.

-- PeterThoeny - 2010-12-08