Feedback on DateFieldPlugin

-- CrawfordCurrie - 10 Dec 2004

Thanks Crawford (and contracting company) for contributing this useful Plugin.

I fixed some formatting on the topic: Plugin Info table and Related Topics. Would be nice to get the benchmarks as well.

-- PeterThoeny - 10 Dec 2004

Some questions:

• Will this be part of the future CorePackage?
• Will the functionalities of TWikiForms and EditTablePlugin be consolidated?
• Will this support MultipleFormsPerTopic someday?
• ...

-- FranzJosefSilli - 10 Dec 2004

• Probably not
• Not by me
• Can't see why not
• Perhaps

-- CrawfordCurrie - 20 Dec 2004

-- FranzJosefSilli - 20 Dec 2004

Dunno, if plugin development for Dakar and beyond is discussed here, but if...

I'd like to have the date output format of the JSCalendarContrib configurable by the admin. Patch (DateFieldPlugin.pm.OutputFormat) supplied. Patch is against DEVELOP svn #7147 (more or less).

-- OliverKrueger - 24 Oct 2005

That is the right place, same place to discuss Plugin features.

-- PeterThoeny - 01 Nov 2005

It would also be nice if there was some way of specifying no date (e.g. a blank box instead of a box with a date in it).

Also, I have to agree with OliverKrueger - the current default format of dates don't sort very well with the edit table plugin.

-- BruceDawson - 26 Dec 2005

Added patch for configurable output and sortable date format(TWiki tables) is set as standard (SVN 8083)

-- AndreUlrich - 04 Jan 2006

I am not using this Plugin, just reading "This will display an uneditable text field and a date selection icon that can be clicked". It occures to me that it would be more flexible to have a short edit field and a clickable icon.

-- PeterThoeny - 10 Jan 2006

Oops, also here, my changes are gone. Please check the Dev topic once in a while! Please understand that I am already working many hours a day on open source TWiki and simple cannot allocate more time to mail the author, file a bug or do the doc fixes myself.

Suggestions:

• Avoid "here" links
• Link to old version is broken
• Left & right cell align problem in Info table
• Heading level issue (use level one only once on top)
• Lincense link broken
• Missing Appraisal row
• Use full URL instead of Interwiki links for home, dev and appraisal links
• Not working Interwiki link in related topics

-- PeterThoeny - 28 Feb 2006

Thanks for a great plugin. I'd like to use the calendar in a html form, so the user doesn't have to go in edit mode to change the date.

Does anybody knwo of a way to easily use something like this calendar in a html form?

-- JosMaccabiani - 01 May 2006

Forms are rendered as HTML forms in edit mode, so you could look at the source code of the form to figure out how to do that.

-- MeredithLesly - 01 May 2006

Sure, but you need to do a (small) bit of Javascript.

My advice is to have a look at the action editor in ActionTrackerPlugin. That is basically just an HTML form....

-- CrawfordCurrie - 01 May 2006

With Bugs:Item2054 fixed and JSCalendarContrib updated, this plugin is once again working with Firefox and PatternSkin.

-- SteffenPoulsen - 19 May 2006

I patched my local copy to show the current date as default in the input box, dunno if people find this useful. If so, I could patch the distriburion version over here too. The change is quite simple, and for general use should probably be conditional on the value in the form (eg, '$current' or something). Here is the line I added:

sub renderFormFieldForEditHandler {
    my ( $name, $type, $size, $value, $attributes, $possibleValues ) = @_;
    my $calendarOutputFormat = TWiki::Func::getPreferencesValue('DATEFIELDPLUGIN_DATEFORMAT') || '%d %b %Y';
     return unless $type eq "date";

+    $value=strftime($calendarOutputFormat,localtime(time));

     my $content =
       CGI::image_button(

-- KoenMartens - 23 Jun 2006

Please do not patch the distribution version! This plugin is maintained under subversion control, and any changes you make will simply be wiped next time I generate a new release.

Feel free to attach a patch to this topic, however.

-- CrawfordCurrie - 25 Jun 2006

Isn't that asking too much from the contributor? The one line change patch is already here in the Dev topic.

-- PeterThoeny - 27 Jun 2006

I just installed that on a Dakar 4.0.4 and it's not working with FireFox. I'll try to figure out what needs to be done to fix it. Do I need to update JSCalendarContrib ?

-- StephaneLenclud - 21 Aug 2006

FireFox patch: From reading Bugs:Item2054 I figured I had to comment out a z-index:1; line from pub/TWiki/PatternSkin/layout.css. There are several z-index:1; lines in that CSS file. Commenting out the one in the #patternOuter block does the trick. Does not look like there is any side effect.

-- StephaneLenclud - 22 Aug 2006

I thought that had been fixed in pattern skin. If not, please report a bug (in http://develop.twiki.org/~develop/cgi-bin/view/Bugs) against Extension PatternSkin

I just uploaded a version that incoporates Koen's suggestion.

-- CrawfordCurrie - 22 Aug 2006

Found a bug in the installer script: perl ./DateFieldPlugin_installer.pl syntax error at ./DateFieldPlugin_installer.pl line 310, near ""{$major}{$minor}";"

Missing a closing bracket - Is this the place to report bugs ?

-- GlennRoberts - 24 Oct 2006

Yes, on top you see a bullet "Please report bugs below". Although typically, Crawford prefers to track bugs in the Bugs:WebHome web.

-- PeterThoeny - 24 Oct 2006

Just FYI, in the Core TWiki date field editing using the JS calendar will be available in 4.1.

-- ThomasWeigert - 26 Oct 2006

I am running into a problem with the plugin defaulting to setting the date to today. This is because I have certain apps where date fields needs to remain blank until set but the default behavior forces the blank ones to today on any edit of the topic. I have modified a local copy of the plugin to have the default behavior as no default. I added a new preference called DATEFIELDPLUGIN_DEFAULTTOTODAY which can be set to '1' if you want it to default to today. I think this is improved behavior and in line with the original suggestion by KoenMartens. If no one objects, I'll check in the new version into subversion.

-- RickMach - 31 Oct 2006

Please do check this in. I will see whether your mod should be taken into the core also. I don't think I am actually initializing the field in core to anything, if there is not an initial value set in the form. I am surprised that this plugin would do so....

-- ThomasWeigert - 01 Nov 2006

I have checked in this version to subversion and built and uploaded a new release of the plugin with this change.

-- RickMach - 01 Nov 2006