Feedback on CalendarPlugin2

-- PavelJenicek - 2010-01-21

Thank you very Pavel much for contributing an improved calendar plugin! The new look is so much nicer (Google like), and very useful to support hours. Rather than forking the plugin, I very much would prefer to replace the CalendarPlugin with your implementation, and to go back to use %CALEDNAR{}% instead of %CALEDNAR2{}%. Is your plugin upward compatible? Seems like from glancing over the syntax rules.

Also, please consider maintaining your plugin in SVN. More at ReadmeFirst and PluginsInSubversion.

-- PeterThoeny - 2010-01-23

I am sorry for no long answer.

Syntax is full compatible it is just time expanded.

We have decided to edit code and use original tag %CALEDNAR{}% and also replace the CalendarPlugin with the new one.There are also another things that should be mentioned. The new look do not support all attributes, which was available in CalendarPlugin. There is a list with note if it is working or not.

• lang="language" OK
• daynames="Mon|Tue|..." OK
• header="..." only in oldcalendar
• weekstartsonmonday="1" or "0" OK
• showdatenumbers="0" only in oldcalendar
• showweekdayheaders="1" only in oldcalendar
• weekdayheadersbig="0" only in oldcalendar
• cellalignment="left" only in oldcalendar
• vcellalignment="middle" only in oldcalendar
• cellheight="n" only in oldcalendar
• border only in oldcalendar
• nowrap only in oldcalendar
• format="..." only in oldcalendar
• all colors only in oldcalendar
• aslist dont work
• months OK

For full compatibility with old calendar plugin, there will be attribute "newcalendar" which, in my opinion, should be default 0. In this case, if someone upgrade his CP it will take no chage in look of his calendar. But if users want to use our new look, they will have to specify "newcalendar=1" .

So do you agree with our scheme?

-- PavelJenicek - 2010-02-14

Thanks for posting the plugin!

It looks like the unsupported items are mainly visual, except for the aslist feature. Therefore I think it is good to merge your plugin over to the CalendarPlugin. I suggest to have the switch the other way, e.g. oldspec="1" if a user wants the old behavior. This introduces a small incompatibility, but you gain many more features and a much improved look.

If you add the aslist feature to your code base it would be OK to ask users who want the old visual look/switches to download an earlier version of the CalendarPlugin, e.g. you could completely replace the existing code with your new code.

-- PeterThoeny - 2010-03-29

Pavel, I did some improvements and fixes to the CalendarPlugin. Do you have time to merge that and your code base back into CalendarPlugin?

-- PeterThoeny - 2011-02-18