Question

The 'interweave' render style in the history rdiff script does not appear to work in version 4.1.1

Using the HistoryPlugin difference facility and selecting the default "Interweave" display format results in an empty box of changes.

The URL that it produces is:

http://sam/twiki/bin/rdiff/Development/WebHome?type=diff&rev1=33&rev2=32&render=interweave&context=-1

The "Side-by-side" format works fine.

Clicking on the '<' between the two versions at the bottom of the topic gives the correct changes.

Environment

-- DuncanKinnear - 18 Mar 2007

Answer

If you answer a question - or have a question you asked answered by someone - please remember to edit the page and set the status to answered. The status is in a drop-down list below the edit box.

By the way, a colleague has 'fixed' this with the following code in the diff script in /var/www/twiki/lib/TWiki/UI/RDiff.pm :

    my $renderStyle = $query->param('render') ||
      $session->{prefs}->getPreferencesValue( 'DIFFRENDERSTYLE' ) ||
        'sequential';
    # Geoff 16 Mar 2007
    $renderStyle = 'sequential' if $renderStyle eq 'interweave';

    my $diffType = $query->param('type') || 'history';

-- DuncanKinnear - 18 Mar 2007

added link to HistoryPluginDev - I don't think twiki ever had a 'interweave' render style - so I would think thats a simple fix to be made in the plugin.

-- SvenDowideit - 29 Apr 2007

it was the CompareRevisionsAddOn that added the 'interweave' format (see SVN:twikiplugins/CompareRevisionsAddOn/lib/TWiki/UI/Compare.pm). so, try installing that. i'm not sure what its status is w.r.t twiki 4; although i did some updates of those addons a while ago... (and i think SteffenPoulsen did some repair work on these, too)

-- WillNorris - 29 Apr 2007

Hmmm. But it worked fine in version 4.0.5.

Something in the core 4.1.1 code appears to have 'broken' this feature.

-- DuncanKinnear - 29 Apr 2007

Another reason we need to try hard to make a StableSkinInterface.

-- PeterThoeny - 29 Apr 2007

huh? This is one plugin depending on another plugins urlparam - TWiki core has never supported 'interweave'.

I'm wondering if Duncan is actually saying that CompareRevisionsAddOn has been broken by something that has changes??

-- SvenDowideit - 29 Apr 2007

this has nothing to do with the skin (afaict) and everything to do with the fact that CompareRevisionsAddOn ships (shipped?) its own version of Compare.pm

-- WillNorris - 30 Apr 2007