Tags:
create new tag
, view all tags

Feature Proposals » Stop specifying style of TOC in the system web

Summary

Current State: Developer: Reason: Date: Concerns By: Bug Tracking: Proposed For:
MergedToCore HideyoImazu AcceptedByReleaseMeeting 2015-09-16   TWikibug:Item7690 KampalaRelease

Edit Form

TopicSummary:
CurrentState:
CommittedDeveloper:
ReasonForDecision:
DateOfCommitment:   Format: YYYY-MM-DD
ConcernRaisedBy:
BugTracking:
OutstandingIssues:
RelatedTopics:
InterestedParties:
ProposedFor:
TWikiContributors:
 

Motivation

TWikiVariables and a few other topics in the system web have a div tag surrounding %TOC% specifying style directly:

<div style="float:right; background-color:#EBEEF0; margin:0 0 -3em 20px; padding: 0 10px 0 10px;">%TOC{title="Contents:"}%</div>
The style specification may not be suitable for other skins than the topmenu-pattern skin combo.

Description and Documentation

Original design

  1. Introduce the class parameter to %TOC%.
  2. Replace the direct style specification as shown above with %TOC{title="Contents:" class="twikiToc twikiTocFloat"}%
  3. Add a definition of the twikiTocFloat class to style sheets

Revised design

It turned out that the above design does not work. Simply having ".twikiTocFloat {float:right; background-color:#EBEEF0; margin:0 0 20px 20px; padding: 0 10px 0 10px;}" in style.css of the pattern skin and then having <div class="twikiToc twikiTocFloat"> in place of <div class="twikiToc"> don't yield the same result as now. This is because what you can do with a nested div is broader than you can do with a single div.

As such, here's the revised design

  1. put ".twikiTocFloat {float:right; margin:0 0 20px 20px; padding: 0 10px 0 10px;}" in style.css and put ".twikiTocFloat {background-color:#EBEEF0;}" in colors.css
  2. replace
    <div style="float:right; background-color:#EBEEF0; margin:0 0 -3em 20px; padding: 0 10px 0 10px;">
    with
    <div class="twikiTocFloat">

Examples

Impact

WhatDoesItAffect: Documentation

Implementation

-- Contributors: Hideyo Imazu - 2015-09-16

Discussion

Makes sense!

-- Peter Thoeny - 2015-09-16

Edit | Attach | Watch | Print version | History: r6 < r5 < r4 < r3 < r2 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r6 - 2015-10-01 - HideyoImazu
 
  • Learn about TWiki  
  • Download TWiki
This site is powered by the TWiki collaboration platform Powered by Perl Hosted by OICcam.com Ideas, requests, problems regarding TWiki? Send feedback. Ask community in the support forum.
Copyright © 1999-2017 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.