Tags:
create new tag
, view all tags

Feature Proposals » Remove inconsistency regarding copyright

Summary

Current State: Developer: Reason: Date: Concerns By: Bug Tracking: Proposed For:
AcceptedProposal TWiki:Main.ThomasWeigert AcceptedBy7DayFeedbackPeriod 2010-09-24     KampalaRelease

Edit Form

TopicSummary:
CurrentState:
CommittedDeveloper:
ReasonForDecision:
DateOfCommitment:   Format: YYYY-MM-DD
ConcernRaisedBy:
BugTracking:
OutstandingIssues:
RelatedTopics:
InterestedParties:
ProposedFor:
TWikiContributors:
 

Motivation

Pattern Skin ignores a standard template definition of copyright, thus making updating templates confusing.

twiki.tmpl defined a template copyright which is used in standardfooter. This template defines the copyright message.

Pattern Skin does not use standardfooter but uses bottombar instead. However, instead of using copyright as you would imagine, it includes TWiki.WebBottomBar, which then defines the copyright message.

Assuming it is desireable that the WebBottomBar is defined in the TWiki web (which I personally doubt as that web should not be customized, thus making the whole exercise somewhat useless), what one would have expected is that WebBottomBar refers to the copyright template. Instead, it just includes the content of that template literally.

I believe the reason for this inconsistency was the desire not to have template notation in a template that is, theoretically, user-editable. (The philosophy appeared to have been that there are several easier customizable templates in Pattern Skin: WebTopBar, WebBottomBar, and WebLeftBar. The mistake about this philosophy, by the way, was to stick these into the TWiki web, making customization of these impractical. These should have been in the Main web, if at all.)

Templates are already confusing as it is. Having gratuitous inconsistencies makes the situation worse.

Description and Documentation

Redefine TWiki.WebBottomBar to use the copyright template rather than inlining its contents. It works just the same. I believe that the argument that the user visible template should not include template notation does not hold water as anybody monkeying with this template needs to understand the whole templating system anyways.

Examples

Impact

Implementation

-- Contributors: ThomasWeigert - 2010-09-24

Discussion

Agreed.

-- PeterThoeny - 2010-09-28

No concerns have been raised, this is now a proposal that is AcceptedBy7DayFeedbackPeriod.

-- PeterThoeny - 2010-10-02

Ping after two years. What happened to the implementation and doc update of this feature? We will park this proposal unless there is some action. Anyone: feel tree to claim this as a committed developer to implement this.

-- PeterThoeny - 2012-10-18

Edit | Attach | Watch | Print version | History: r6 < r5 < r4 < r3 < r2 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r6 - 2013-10-11 - PeterThoeny
 
  • Learn about TWiki  
  • Download TWiki
This site is powered by the TWiki collaboration platform Powered by Perl Hosted by OICcam.com Ideas, requests, problems regarding TWiki? Send feedback. Ask community in the support forum.
Copyright © 1999-2017 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.