Bug: Saving a page without changing it commits a null-diff revision

With '$doKeepRevIfEditLock = "0";', saves without edits still commit a new revision of a page.

Test case

Edit a page and save without modifying the contents. TWiki checks the unedited page into RCS again. Look at the diff and see no changes.

Environment

-- RobertDeForest - 05 Feb 2006

Impact and Available Solutions

I haven't investigated the impact or possible solutions because this is such a trivial bug.

Follow up

In case it's not already clear, this is a rediculously trivial and unimportant bug, and I only submitted it for completeness sake. The work-around is "don't do that", or "just click Cancel instead of saving".

Also, while I did search for a pre-existing report of this bug, I may have missed one if it existed, and if so I appologize.

-- RobertDeForest - 05 Feb 2006

:), funny, my thought was, yep, thats not a bug at all same thing happens when you open and save a word doc right?

-- SvenDowideit - 05 Feb 2006

I do not consider this a bug, but a nice to have feature. In fact, it was a feature in pre-Cairo TWikis: You could change a topic (which bumped the version up), you could do follow-up saves within the window (same bumped up version), and you could remove your changes (and the revision got reverted back to the previous version if done by the same person). Now that is a nice feature we lost in the past.

-- PeterThoeny - 06 Feb 2006

Fix record

Discussion