Tags:
create new tag
, view all tags

Bug: Lock recovery causes failed CI attempt

In Store.pm, around line 961, there is an errant:

  $tmp = $TWiki::revCiCmd;

This overwrites the already interpolated version of $tmp constructed about 20 lines earlier. This causes an attempt to checkin the file named (literally) %USERNAME% which fails.

Deleting this line removes the bug.

Test case

  • Somehow stimulate a lock problem, then attempt to save some changes. Observe, in the web server log the cryptic ci command error.

Environment

TWiki version: 01 DEC 2001
TWiki plugins: as distributed
Server OS: FreeBSD
Web server: Apache
Perl version: 5.005_03
Client OS: FreeBSD
Web Browser: Netscape

-- RobertWithrow - 11 Jan 2002

Fix record

Thanks for pointing out. Is fixed andin TWikiAlphaRelease.

-- PeterThoeny - 16 Feb 2002

This was not correctly fixed.

The "bugfix" was to correct the fact that the ci command further up the code was being overwritten. But in the interim, variable names have changed, and the original meaning of the code lost.

Corrected code is in SVN rev 3284, DEVELOP branch

Note that this fix means that RelockRcsFiles is no longer necessary, and should be removed. Sorry MattWilkie frown

-- CrawfordCurrie - 23 Nov 2004

Awhhh. frown So much for my 3 months of TWikiContributor fame (which was mostly due to Crawford and Sven anyway). smile This sounds like a cleaner solution in any case.

-- MattWilkie - 24 Nov 2004

Edit | Attach | Watch | Print version | History: r4 < r3 < r2 < r1 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r4 - 2004-11-24 - MattWilkie
 
  • Learn about TWiki  
  • Download TWiki
This site is powered by the TWiki collaboration platform Powered by Perl Hosted by OICcam.com Ideas, requests, problems regarding TWiki? Send feedback. Ask community in the support forum.
Copyright © 1999-2017 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.