Tags:
create new tag
, view all tags

Patch Proposal: TOCs are rendered into invalid html

Motivation

getting Dakar bugfree

Description

This is a two-chars patch prevents the twikiToc div and its contained anchors to be crossed html-wise. Prevoiusly, the closing div was appended to the last char of the TOC result with the effect that it will be _enclosed _ in the list that gets rendered later on in getRenderedVersion()

Adding a \n to the TOC before surrounding it with a div fixes that.

The problem showed up by trying to draw a red border arround TOCs using

.twikiToc {border:1px solid red}

Firefox is quite good in rendering crossed html tags. Not so konqueror which drawed a red border arround the complete topic text.

Note: Patch is attached as http://www.twiki.org/p/pub/Codev/InvalidHtmlInTOC/TWiki_pm.diff. The patch is against Dakar.

-- MichaelDaum - 28 Mar 2005


Discussion:

Fixed. SVN r.3934

-- ArthurClemens - 28 Mar 2005

Topic attachments
I Attachment History Action Size Date Who Comment
Unknown file formatdiff TWiki_pm.diff r2 r1 manage 0.4 K 2005-03-28 - 22:01 UnknownUser  
Edit | Attach | Watch | Print version | History: r2 < r1 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r2 - 2005-03-28 - ArthurClemens
 
  • Learn about TWiki  
  • Download TWiki
This site is powered by the TWiki collaboration platform Powered by Perl Hosted by OICcam.com Ideas, requests, problems regarding TWiki? Send feedback. Ask community in the support forum.
Copyright © 1999-2017 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.