Tags:
create new tag
, view all tags
Except for HardwiredRDiffColours, there are a couple of other places with hard coded colors. Hard coded colours make it difficult for skins to be consistent, and should be replaced with CSS variable names. See HardwiredRDiffColours for Colas suggestion.

TWiki.pm, line 376 (sub initialize):

    # Add background color and font color (AlWilliams - 18 Sep 2000)
    # PTh: Moved from internalLink to initialize ('cause of performance)
    $newTopicBgColor   = TWiki::Prefs::getPreferencesValue("NEWTOPICBGCOLOR")   || "#FFFFCE";
    $newTopicFontColor = TWiki::Prefs::getPreferencesValue("NEWTOPICFONTCOLOR") || "#0000FF";

Setting of the background colour (and text colour) of non existant wiki words is used in conjunction with NonExistentWordMarker (the infamous ?).

Looking at the code, this colour supposedly is a preference variable, although I don't see it listed in the WebPreferences of the distribution. How am I supposed to know it exists? I tried to change it myself, but I don't see any difference. I would say this is a bug.

TWiki.pm, line 1534 (sub showError):

    return "<font size=\"-1\" color=\"#FF0000\">$errormessage</font>" ;

If I want to have a red theme, a red colour won't help me much...

TWiki.pm, line 2124 (sub renderFormData):

    $metaText .= "<th colspan=\"2\" align=\"center\" bgcolor=\"#99CCCC\"> $name </th></tr>\n";        

and line 2130:

        $metaText .= "<tr><th bgcolor=\"#99CCCC\" align=\"right\"> $title:</th><td align=\"left\"> $value </td></tr>\n";

TWiki.pm, line 2142 (sub emitTR):

            $text .= "<th$attr bgcolor=\"#99CCCC\"> $1 </th>";

Form.pm, line: 179 (sub link):

          $attr = ' bgcolor="#99CCCC"';

Setting the background colour of the form th.

-- ArthurClemens - 05 Aug 2003

There are other ones too (alpha release, 2003-Jul-01). Find them with grep -Rn 'color=' $twiki/lib/* (a simplistic search; there are probably others)

TWiki/Form.pm:186:
       $attr = ' bgcolor="#99CCCC"';
TWiki/Plugins/TablePlugin.pm:149:
       $_[0] =~ s/(<font )tablepluginfixlinkcolor.*?(color=\")([^\"]*)(\">.*?<\/font>)/&fixLinkColor("$1$2$3$4",$3)/geo;
TWiki/Plugins/TablePlugin.pm:544:
       $attr .= " bgcolor=\"$headerBg\"" unless( $headerBg =~ /none/i );
TWiki/Plugins/TablePlugin.pm:556:
       $color = "<font tablepluginfixlinkcolor=\"on\" color=\"$headerColor\">" if( $headerColor );
TWiki/Plugins/TablePlugin.pm:579:
       $attr .= " bgcolor=\"$color\"" unless( $color =~ /none/i );
TWiki/Plugins/TablePlugin.pm:587:
       $color = "<font color=\"$color\">";
TWiki/Plugins/TablePlugin.pm:610:
       $color = "<font color=\"$color\">";
TWiki/Search.pm:600:
       my $subs = s|$match|$1<font color="red">$2</font>&nbsp;|g;
TWiki/Search.pm:602:
       $subs += s|$match|$1<font color="red">$2</font>&nbsp;|gi;
TWiki.pm:1555:
        return "<font size=\"-1\" color=\"#FF0000\">$errormessage</font>" ;
TWiki.pm:2354:
        $$colData{"attr"} = $attr . " bgcolor=\"#99CCCC\"";
TWiki.pm:2531:
        .  "<font color=\"$newTopicFontColor\">$theLinkText</font></span>"

-- MattWilkie - 05 Aug 2003

What about using this a test of the new process that Peter promised. I can volunteer (if nobody else wants to do it) to make the changes and propose a patch, how can we proceed?

But I would like that people can apply my changes, once approved and validated by the Core Team, to running production TWikis in a reasonable time...

-- ColasNahaboo - 06 Aug 2003

I would like to ask those that know more thai I about this stuff to decide

  1. that we are going to add css tags to all major objects ( at least initially where colours are set (while leaving the non-css defaults for basic usage ) as Arthur suggests on HardwiredRDiffColours
  2. a consistent naming scheme for the tags (preferably with type, context and detail info)
  3. come up with some documentation mechanism (mmm, can we add something like the PerlDocPlugin )

the sooner the better as I am working in rdiff right now smile (otherwise you'll have to live with my braindead implementation decisions smile )

-- SvenDowideit - 26 Mar 2004

All locations with hardwired colors do now have css tags as well. This means that the hardwired colors are still there, but now they are addressable with a style sheet.

-- ArthurClemens - 01 Aug 2004

TWiki emitted CSS is listed in TWikiCss

Edit | Attach | Watch | Print version | History: r7 < r6 < r5 < r4 < r3 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r7 - 2004-08-08 - ArthurClemens
 
  • Learn about TWiki  
  • Download TWiki
This site is powered by the TWiki collaboration platform Powered by Perl Hosted by OICcam.com Ideas, requests, problems regarding TWiki? Send feedback. Ask community in the support forum.
Copyright © 1999-2017 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.